Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct message reviewers #40

Open
sudowork opened this issue Aug 11, 2016 · 3 comments
Open

Direct message reviewers #40

sudowork opened this issue Aug 11, 2016 · 3 comments

Comments

@sudowork
Copy link
Contributor

Are there any plans to support direct messaging reviewers? Of course this would involve needing to know a mapping of phabricator usernames -> slack usernames, which could make things difficult. The reason for requesting this feature is that the phabricator feed gets pretty noisy relatively quickly. Even with selective mentions/highlighting, self-actions can be quite a lot to filter through. The last piece of reasoning is that, although the summon command is useful, it requires a user to manually take action.

@etcinit
Copy link
Owner

etcinit commented Feb 20, 2017

While summon now supports properly mentioning user's by their Slack username, it does not message them directly. This could be something that could be added as an option to the command.

However, doing this automatically is difficult because the feed events don't have metadata that let us easily figure out the type of event in a programmatic way. The only way I can think of doing this is using regular expressions which is a bit hacky. Phabricator's own bot seems to do this to some extent: https://github.com/phacility/phabricator/blob/master/src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php#L79

@sudowork
Copy link
Contributor Author

sudowork commented Mar 16, 2017

Thanks a bunch @etcinit ! Summoning w/ an @mention is great.

What about in the form of a direct message? Since the commit you mention has the ability to find Slack usernames for reviewers on a revision, could the bot just DM the individual?

I guess the main goal here is to notify the reviewer, but not spam a channel too much.

@schemar
Copy link
Collaborator

schemar commented Mar 12, 2018

Sorry, but the bot is no longer maintained and I wouldn't know how to do this cleanly. I will leave the task open in case someone wants to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants