Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETP-166: Unit test testDiscountWithoutDocTypeConfigured hangs during execution in Oracle #448

Closed
valeg-etendo opened this issue Aug 6, 2024 · 1 comment
Closed

ETP-166: Unit test testDiscountWithoutDocTypeConfigured hangs during execution in Oracle #448

valeg-etendo opened this issue Aug 6, 2024 · 1 comment
Assignees
@jortolanosmf
Labels
bug Something isn't working

Comments

@valeg-etendo
Copy link
Collaborator

Error's description

The unit test testDiscountWithoutDocTypeConfigured is designed to verify that if an internal consumption is posted and the document type with the category 'Material Internal Consumption' is removed, it should not be possible to unpost it. While this test passes without issues on PostgreSQL, it hangs during the execution of OBDal.getInstance().flush() when run on Oracle.

Steps to reproduce the error

  1. Up Etendo Classic with Oracle database
  2. Execute the unit test testDiscountWithoutDocTypeConfigured.

Expected behavior

The flush operation should complete without issues, allowing the test to proceed and verify that the internal consumption cannot be unposted.

Affected Version

Etendo Classic 24.2.4
Database: Oracle

Solution Design (optional)

Other test cases

Given:
When:
Then:
@valeg-etendo valeg-etendo added the bug Something isn't working label Aug 6, 2024
@jortolanosmf jortolanosmf self-assigned this Aug 7, 2024
@jortolanosmf jortolanosmf linked a pull request Aug 8, 2024 that will close this issue
Issue #428: Refactor accounting tests in Internal consumption #451
Closed
jortolanosmf added a commit that referenced this issue Aug 8, 2024
@jortolanosmf
Issue #448: Refactored accounting tests in Internal consumption
037528d 
ETP-166: The crash caused by the testDiscountWithoutDocTypeConfigured test when trying to remove the document type has been fixed, and improvements have been made to the accounting tests for Internal consumption. Specifically, unnecessary commits have been removed, modularity improvements, cleanup blocks and documentation in the methods.
jortolanosmf added a commit that referenced this issue Aug 8, 2024
@jortolanosmf
Issue #448: Refactored accounting tests in Internal consumption
ec1b12f 
ETP-166: The crash caused by the testDiscountWithoutDocTypeConfigured test when trying to remove the document type has been fixed, and improvements have been made to the accounting tests for Internal consumption. Specifically, unnecessary commits have been removed, modularity improvements, cleanup blocks and documentation in the methods.
jortolanosmf added a commit that referenced this issue Aug 9, 2024
@jortolanosmf
Issue #448: StringUtils added and code improvements
1328f7a 
ETP-166: StringUtils added and code improvements
jortolanosmf added a commit that referenced this issue Aug 9, 2024
@jortolanosmf
Issue #448: StringUtils added and code improvements
1258dc7 
ETP-166: StringUtils added and code improvements
valeg-etendo added a commit that referenced this issue Aug 9, 2024
@valeg-etendo
Merge pull request #452 from etendosoftware/hotfix/#448-ETP-166
8fa6967 
Issue #448: Refactored accounting tests in Internal consumption
@valeg-etendo
Copy link
Collaborator Author

Important

Bug resolved in version 24.2.5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jortolanosmf jortolanosmf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #428: Refactor accounting tests in Internal consumption etendosoftware/etendo_core
2 participants
@valeg-etendo @jortolanosmf