Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #290: Description field size is changed from 'String' to 'Text' in C_Order table #303

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

tomirodeghiero
Copy link
Contributor

@tomirodeghiero tomirodeghiero commented Jan 31, 2024

EPL-1214: The field reference type in C_Order table change from 'String' to 'Text'

@Gremiger
Copy link
Contributor

Is this PR ok? Because the description doesn't match with the entirety of the changelist

@tomirodeghiero
Copy link
Contributor Author

tomirodeghiero commented Jan 31, 2024

Is this PR ok? Because the description doesn't match with the entirety of the changelist

It is not okay @Gremiger. When I executed export.database, it brought in many changes that shouldn't have been impacted. I will soon commit to removing the unnecessary changes because I wasn't aware that there were changes that shouldn't be uploaded. I thought these were the correct ones. Thank you for letting me know

@valenvivaldi
Copy link
Contributor

Always remember to check carefully what is added to the git stage before committing.

@tomirodeghiero
Copy link
Contributor Author

Always remember to check carefully what is added to the git stage before committing.

@valenvivaldi I completely agree. I thought the changes I was uploading (since it was the only thing I modified in export.database, and I had a clean tree of changes before running it) were fine. Thank you very much for the advice, I agree that it's essential to do it before committing

@isaiasb-etendo will soon provide me with a command to clean up the things that shouldn't have been uploaded

EPL-1214: The field reference type in C_Order table change from 'text' to 'String'
@tomirodeghiero tomirodeghiero changed the title Issue #290: Description field size is changed from 'text' to 'String' in C_Order table Issue #290: Description field size is changed from 'String' to 'Text' in C_Order table Feb 1, 2024
@tomirodeghiero tomirodeghiero merged commit d2633f2 into main Feb 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPL-1214: Reference type error in the 'Description' field of the sales order window (c_order).
4 participants