Issue #397: Fixed aliases in HQL query of DJOBS_CreateFromOrders.

[Matias-Bernal]

EPL-1505: Fixed projection aliases in HQL query of DJOBS_CreateFromOrders table to allow added new fields on query projections.

[etendobot]

Warning

Git Police 👮

Invalid pull request title. Make sure it contains the appropriate issue/task reference and is descriptive of the change made.

For more information, visit: Methodology for repository managment

[sonarscanetendo]

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• No coverage information (0.00% Estimated after merge)
• No duplication information (13.20% Estimated after merge)

Project ID: etendosoftware_etendo_core_AYOKvQCAuJ79WHyLB97g

View in SonarQube

[etendobot]

GPT Review for AD_TABLE.xml

Review

• Estimated effort to review [1-5]: 2, because the changes are straightforward and involve renaming columns for consistency. The changes are easy to understand and verify.
• Score: 95

Code feedback

• File:
  modules_core/com.smf.jobs.defaults/src-db/database/sourcedata/AD_TABLE.xml
• Language:
  xml
• Suggestion:
  Ensure that the column aliases are consistent and follow the naming conventions used throughout the project. This helps maintain readability and consistency in the codebase. [important]
• Label:
  best practice
• Existing code:

ic.documentNo as documentNo,
bp.name as cbpartnername,
ic.orderDate as orderDate,

• Improved code:

ic.documentNo as documentNo,
bp.name as cbpartnerName,
ic.orderDate as orderDate,

• File:
  modules_core/com.smf.jobs.defaults/src-db/database/sourcedata/AD_TABLE.xml
• Language:
  xml
• Suggestion:
  Ensure that the column aliases are consistent and follow the naming conventions used throughout the project. This helps maintain readability and consistency in the codebase. [important]
• Label:
  best practice
• Existing code:

ic.term as TermName,
ic.orderedQuantity as orderedQuantity,
ic.deliveredQuantity as deliveredQuantity,

• Improved code:

ic.term as termName,
ic.orderedQuantity as orderedQuantity,
ic.deliveredQuantity as deliveredQuantity,

• File:
  modules_core/com.smf.jobs.defaults/src-db/database/sourcedata/AD_TABLE.xml
• Language:
  xml
• Suggestion:
  Ensure that the column aliases are consistent and follow the naming conventions used throughout the project. This helps maintain readability and consistency in the codebase. [important]
• Label:
  best practice
• Existing code:

ic.creationDate as creationDate,
ic.createdBy as createdBy,
ic.updated as updated,
ic.updatedBy as updatedBy

• Improved code:

ic.creationDate as creationDate,
ic.createdBy as createdBy,
ic.updated as updated,
ic.updatedBy as updatedBy

[etendobot]

GPT Review for AD_TABLE.xml

Review

• Estimated effort to review [1-5]: 2, because the changes are straightforward and mostly involve renaming columns for consistency. The review is simple but requires careful checking to ensure all renames are correct and consistent.
• Score: 95

Code feedback

• File:
  modules_core/com.smf.jobs.defaults/src-db/database/sourcedata/AD_TABLE.xml
• Language:
  xml
• Suggestion:
  Ensure that the column aliases are consistently named throughout the entire XML file. This helps maintain readability and reduces the risk of errors in future modifications. [important]
• Label:
  best practice
• Existing code:

ic.salesOrder.id,
o.name as adorgname,
ic.documentType as cdoctypename,
ic.documentNo as documentNo,
bp.name as cbpartnername,
ic.orderDate as orderDate,
case when @linesIncludeTaxes@ = 'Y' then ic.amountlinesgross else ic.amountlines end as amountlines,
case 
    when ic.term = 'N' 
    then 0.0 
    else 
        case when @linesIncludeTaxes@ = 'Y' then ic.notinvoicedlinesgross else ic.notinvoicedlines end
end as notinvoicedlines,
ic.term as TermName,
case 
    when ic.term = 'N' 
    then 0.0 
    else 
        case when @linesIncludeTaxes@ = 'Y' then ic.pendinglinesgross else ic.pendinglines end
end as pendinglines,
ic.orderedQuantity as orderedQuantity,
ic.deliveredQuantity as deliveredQuantity,
((case when @linesIncludeTaxes@ = 'Y' then ic.amountlinesgross else ic.amountlines end)-(case when @linesIncludeTaxes@ = 'Y' then ic.notinvoicedlinesgross else ic.notinvoicedlines end)) as linesinvoiced,
ic.amountlinesgross as totalgross,
ic.creationDate as creationDate,
ic.createdBy as createdBy,
ic.updated as updated,
ic.updatedBy as updatedBy

• Improved code:

ic.salesOrder.id as salesOrderId,
o.name as adorgname,
ic.documentType as cdoctypename,
ic.documentNo as documentNo,
bp.name as cbpartnername,
ic.orderDate as orderDate,
case when @linesIncludeTaxes@ = 'Y' then ic.amountlinesgross else ic.amountlines end as amountlines,
case 
    when ic.term = 'N' 
    then 0.0 
    else 
        case when @linesIncludeTaxes@ = 'Y' then ic.notinvoicedlinesgross else ic.notinvoicedlines end
end as notinvoicedlines,
ic.term as termName,
case 
    when ic.term = 'N' 
    then 0.0 
    else 
        case when @linesIncludeTaxes@ = 'Y' then ic.pendinglinesgross else ic.pendinglines end
end as pendinglines,
ic.orderedQuantity as orderedQuantity,
ic.deliveredQuantity as deliveredQuantity,
((case when @linesIncludeTaxes@ = 'Y' then ic.amountlinesgross else ic.amountlines end)-(case when @linesIncludeTaxes@ = 'Y' then ic.notinvoicedlinesgross else ic.notinvoicedlines end)) as linesinvoiced,
ic.amountlinesgross as totalgross,
ic.creationDate as creationDate,
ic.createdBy as createdBy,
ic.updated as updated,
ic.updatedBy as updatedBy