Feature ETP-801: Fix claims generation

[RomanMagnoli]

No description provided.

[sonarscanetendo]

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 0.00% Coverage (0.00% Estimated after merge)
• 60.00% Duplicated Code (13.20% Estimated after merge)

Project ID: etendosoftware_etendo_core_AYOKvQCAuJ79WHyLB97g

View in SonarQube

[etendobot]

GPT Review for SecureWebServicesUtils.java

Review

• Estimated effort to review [1-5]:
  1, because the changes are straightforward and involve renaming claims in a JWT builder method, which is simple to review.
• Score: 95

Code feedback

• File:
  modules_core/com.smf.securewebservices/src/com/smf/securewebservices/utils/SecureWebServicesUtils.java
• Language:
  java
• Suggestion:
  Consider adding a comment to explain the rationale behind renaming the JWT claims. This can help future developers understand the context and reason for these changes. [medium]
• Label:
  documentation
• Existing code:

.withClaim("user", user.getId())
.withClaim("client", selectedRole.getClient().getId())
.withClaim("role", selectedRole.getId())
.withClaim("organization", selectedOrg.getId())

• Improved code:

// Renamed claims for better clarity and consistency
.withClaim("user", user.getId())
.withClaim("client", selectedRole.getClient().getId())
.withClaim("role", selectedRole.getId())
.withClaim("organization", selectedOrg.getId())

[etendobot]

GPT Review for SecureWebServicesUtilsTest.java

Review

• Estimated effort to review [1-5]:
  2, because the changes are straightforward and involve updating the claim keys in test assertions, which is a simple and clear modification.
• Score: 95

Code feedback

• File:
  src-test/src/com/smf/securewebservices/utils/SecureWebServicesUtilsTest.java
• Language:
  java
• Suggestion:
  Consider adding a comment or updating documentation to reflect the change in claim keys from ad_user_id, ad_role_id, and ad_org_id to user, role, and organization. This will help maintain clarity for future developers who may work with this code. [medium]
• Label:
  documentation
• Existing code:

assertEquals(user.getId(), decodedToken.getClaim("user").asString());
assertEquals(role.getId(), decodedToken.getClaim("role").asString());
assertEquals(org.getId(), decodedToken.getClaim("organization").asString());

• Improved code:

// Updated claim keys to match new token structure
assertEquals(user.getId(), decodedToken.getClaim("user").asString());
assertEquals(role.getId(), decodedToken.getClaim("role").asString());
assertEquals(org.getId(), decodedToken.getClaim("organization").asString());