Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some type hints and warnings #2381

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Fix some type hints and warnings #2381

merged 3 commits into from
Aug 17, 2024

Conversation

Badiboy
Copy link
Collaborator

@Badiboy Badiboy commented Aug 17, 2024

Description

Fix some type hints and warnings

  1. Several typehint fixes
  2. 1 return bug fix
  3. BuiltIn hints suppressed to make hint check easier

@coder2020official
Copy link
Collaborator

LGTM

@Badiboy
Copy link
Collaborator Author

Badiboy commented Aug 17, 2024

Thanks.

Damn. I commited #2382 before merge and it fell here also. Could you please approve also?

@coder2020official
Copy link
Collaborator

coder2020official commented Aug 17, 2024 •
edited
Loading

I'd add typehints(return types for both funcs)

@Badiboy
Copy link
Collaborator Author

Badiboy commented Aug 17, 2024 •
edited
Loading

Typehints for functions added

@Badiboy Badiboy merged commit e077d21 into eternnoir:master Aug 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coder2020official coder2020official coder2020official approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Badiboy @coder2020official