Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to change a note's collection #120

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Jan 21, 2021

… aka move notes.

In practice: copy the item into another collection and delete the old one.

This fixes #112.

Tested on web Firefox Linux
Tested on native Android

Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have it as an explicit move operation rather than just being able to change the collection and have this done, as it has non-obvious implications for now (the fact that it's deleted and a new one is created).

src/screens/NoteListScreen.tsx Outdated Show resolved Hide resolved
@zecakeh
Copy link
Contributor Author

zecakeh commented Jan 21, 2021

I created a new screen to move the notes, I don't know if that's what you had in mind.

@tasn
Copy link
Member

tasn commented Feb 21, 2021

Yeah, that's what I had in mind! :)

@tasn tasn merged commit 312ffbe into etesync:master Feb 21, 2021
@zecakeh zecakeh deleted the move-note branch February 21, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to move a note to another notebook
2 participants