Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .env to .gitignore after brownie init #1168

Closed
PatrickAlphaC opened this issue Jul 28, 2021 · 4 comments · Fixed by #1249
Closed

Add .env to .gitignore after brownie init #1168

PatrickAlphaC opened this issue Jul 28, 2021 · 4 comments · Fixed by #1249

Comments

@PatrickAlphaC
Copy link
Contributor

Overview

Add .env to .gitignore after brownie init

So that people who use environment variables can have a little more protection.
@iamdefinitelyahuman
Copy link
Member

Sounds good!

@ptisserand
Copy link
Contributor

Hi @iamdefinitelyahuman, could I work on this issue ?

@iamdefinitelyahuman
Copy link
Member

gladly :)

@ptisserand
Copy link
Contributor

Hi @iamdefinitelyahuman do you think it's necessary to add .gitignore content checking in tests/project/main/test_main_project.py ?

ptisserand added a commit to ptisserand/brownie that referenced this issue Sep 10, 2021
@ptisserand
GH-eth-brownie#1168: add .env to .gitignore after brownie init
76e9d39
@ptisserand ptisserand mentioned this issue Sep 10, 2021
Merged
4 tasks
iamdefinitelyahuman added a commit that referenced this issue Sep 11, 2021
@iamdefinitelyahuman
Merge pull request #1249 from ptisserand/issue-1168
a1b6dfd 
GH-#1168: add .env to .gitignore after brownie init
ptisserand added a commit to ptisserand/brownie that referenced this issue May 17, 2022
@ptisserand
GH-eth-brownie#1168: add .env to .gitignore after brownie init
6bcc932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-#1168: add .env to .gitignore after brownie init ptisserand/brownie
3 participants
@ptisserand @iamdefinitelyahuman @PatrickAlphaC