Fix - Use GITHUB_TOKEN when downloading zipballs #1055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Have
_stream_download()
also useGITHUB_TOKEN
Related issue: fixes #1054
How I did it
Move
GITHUB_TOKEN
retrieval into standalone helper function, pass headers as optional arguments to_stream_download()
and_get_mix_default_branch()
Looks like this was also not being used in
from_brownie_mix()
.How to verify it
Can try installing a github brownie package from a private repo (it now succeeds).
Not too clear how to easily/reasonably include this in the test cases - the test would probably have to rely on an external AUTH token and an active internet connection, or some swanky mocking.
Checklist