Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not cache eth_newBlockFilter #1061

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Do not cache eth_newBlockFilter #1061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion brownie/network/middlewares/caching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,12 @@ def block_filter_loop(self) -> None:
def process_request(self, make_request: Callable, method: str, params: List) -> Dict:
# do not apply this middleware to filter updates or we'll die recursion death
# clientVersion is used to check connectivity so we also don't cache that
if method in ("eth_getFilterChanges", "eth_uninstallFilter", "web3_clientVersion"):
if method in (
"eth_getFilterChanges",
"eth_newBlockFilter",
"eth_uninstallFilter",
"web3_clientVersion",
):
return make_request(method, params)

# try to return a cached value
Expand Down