don't crash on solidity 0.8.4 typed errors #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wysenynja pls rebase good ser 🙏 |
BlinkyStitt
force-pushed
the
solidity_0.8.4_errors
branch
from
04e7ebf
to
0b9cf88
Compare
|
I don't think we need additional tests. if the existing ones for parsing errors work, then this change is good. |
iamdefinitelyahuman
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Solidity now has typed errors. This keeps parsing them from crashing brownie.
We can figure out actually parsing them in this PR or merge this and do that later.
How I did it
Check for the string selector before trying to parse as a string
How to verify it
revert with the new typed errors.
Checklist