Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursively kill all RPC child processes on exit #1200

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Recursively kill all RPC child processes on exit #1200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16f612a
fix: recursively kill all rpc child processes
shuklaayush Aug 16, 2021
e5c58aa
fix: use 120s timeout for hardhat-fork network
shuklaayush Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ This changelog format is based on [Keep a Changelog](https://keepachangelog.com/
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased](https://github.com/eth-brownie/brownie)
### Fixed
- Recursively kill all RPC child processes on exit ([#1200](https://github.com/eth-brownie/brownie/pull/1200))

## [1.16.0](https://github.com/eth-brownie/brownie/tree/v1.16.0) - 2021-08-08
### Added
Expand Down
1 change: 1 addition & 0 deletions brownie/data/network-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ development:
id: hardhat-fork
cmd: npx hardhat node
host: http://127.0.0.1
timeout: 120
cmd_settings:
port: 8545
fork: mainnet
Expand Down
2 changes: 1 addition & 1 deletion brownie/network/rpc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def kill(self, exc: bool = True) -> None:
print("Terminating local RPC client...")
except ValueError:
pass
for child in self.process.children():
for child in self.process.children(recursive=True):
try:
child.kill()
except psutil.NoSuchProcess:
Expand Down