fix: change lock acquire/release in multicall #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the new thread-safety, we must check the individual values of `_pending_calls`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Ended up testing 4 some different ways to handle this (some combinations as well).
Easiest and quickest was just locking on enter/exit (we'd need to use a RLock to handle reentrancy within the same thread though, and then also handle more reentrancy issues (like maintaining a queue of block numbers). However, opting for locking on queue/bytecode access + per-thread dictionary was what I ended up going with. For now it gets the job done with the least amount of headache.
Will definitely need to revisit this along with reentrancy in the future.