fix: etherscan verification w/ new flattener #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade using `pip-compile requirements-dev.in`
Eliminate recreating the Flattener each time the get_verification_info fn is called
(with the exception of the appended etadata hash)
skellet0r
force-pushed
the
fix/verification
branch
from
8b99c49
to
af7680d
Compare
skellet0r
force-pushed
the
fix/verification
branch
2 times, most recently
from
891e06b
to
c1d529a
Compare
iamdefinitelyahuman
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added a new solidity source code flattener.
This one is not as fancy as using the solidity ast, however, it does come with the benefit that it's extremely robust, since it literally just reads in files and uses import statements to read in files.
Long term however, this sucks flattening the source code, we should really push etherscan to support programmatic verification via standard-json-input, which the Flattener class has support for if that day in the future ever arrives.
Fixes: #1192 #1076
How I did it
Just traverse through the tree, use a bit of regex and voila
How to verify it
This should work with all solidity compiler versions. Test on a bunch, I did sample deployments using the oz mocks library.
Checklist