Fix incremental compilation #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdefinitelyahuman
previously approved these changes
Jan 29, 2022
danhper
force-pushed
the
fix-incremental-compilation
branch
from
6a6be85
to
56e4afa
Compare
iamdefinitelyahuman
approved these changes
Feb 5, 2022
|
@danhper @iamdefinitelyahuman Thanks a lot! Great speed up for big projects 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix issue with the current incremental compilation causing all the contracts to recompile every time.
How I did it
Improved the compiler comparison to avoid comparing things such as "v0.8.10" and "v0.8.10+commit.fc410830" or so.
How to verify it
Compiling any project where the Solidity compiler version is specified should be enough to reproduce.
Checklist