Avoid removing dependencies from the build #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhper
force-pushed
the
avoid-removing-dependencies
branch
from
a932b6f
to
0d9000c
Compare
iamdefinitelyahuman
previously approved these changes
Aug 7, 2022
This solves an issue where some fixtures that were dependencies of the project would be found right after compilation but not in subsequent runs of the tests.
iamdefinitelyahuman
force-pushed
the
avoid-removing-dependencies
branch
2 times, most recently
from
7280bc1
to
bba0272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This solves an issue where some fixtures that were dependencies
of the project would be found right after compilation but not
in subsequent runs of the tests.
How I did it
Only remove build files if they do not have any dependents in the project.
How to verify it
Add an out-of-project dependency and compile twice
Checklist