Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replaces usages of deprecated eth_abi package methods #1639

Conversation

mbaranovski
Copy link
Contributor

@mbaranovski mbaranovski commented Nov 25, 2022

What I did

Running tests using brownie outputs lots of eth-abi package deprecation warnings like:

DeprecationWarning: abi.encode_abi() and abi.encode_abi_packed() are deprecated and will be removed in version 4.0.0 in favor of abi.encode() and abi.encode_packed(), respectively.

Source: https://github.com/ethereum/eth-abi/blob/v2.2.0/eth_abi/abi.py#L11
This PR addresses fixes the warnings.

How I did it

Replaces deprecated methods:

  • encode_abi -> encode
  • decode_abi -> decode

How to verify it

Run the tests using brownie.network.contract functionality and notice lack of above warnings.

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have added an entry to the changelog

@mbaranovski mbaranovski marked this pull request as ready for review November 25, 2022 15:32
@mbaranovski
Copy link
Contributor Author

Hi @iamdefinitelyahuman, that's a small PR do you think we can merge it? Thanks!

@iamdefinitelyahuman iamdefinitelyahuman merged commit c842d53 into eth-brownie:master Jan 29, 2023
@sreyemnayr
Copy link

I see this was merged but am still getting these warnings in 1.19.3 - anyone else?

@cheewen-ho
Copy link

I see this was merged but am still getting these warnings in 1.19.3 - anyone else?

me too...
Have you found a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants