Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to EIP1559-style transactions on live networks #1727

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Default to EIP1559-style transactions on live networks #1727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ef523a
chore: set priority_fee as default behavior for live networks
iamdefinitelyahuman Jan 30, 2024
f3c0dd9
feat: use legacy-style gas if network does not support eip1559
iamdefinitelyahuman Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions brownie/data/default-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ networks:
live:
gas_limit: auto
gas_buffer: 1.1
gas_price: auto
gas_price: null
max_fee: null
priority_fee: null
priority_fee: auto
reverting_tx_gas_limit: false
default_contract_owner: false

Expand Down
7 changes: 6 additions & 1 deletion brownie/network/account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,12 @@ def _make_transaction(
priority_fee = CONFIG.active_network["settings"]["priority_fee"] or None

if priority_fee == "auto":
priority_fee = Chain().priority_fee
try:
priority_fee = Chain().priority_fee
except ValueError:
# fallback to legacy transactions if network does not support EIP1559
CONFIG.active_network["settings"]["priority_fee"] = None
priority_fee = None

try:
# if max fee and priority fee are not set, use gas price
Expand Down
Loading