Fix error_code decoding #1758
Merged
Fix error_code decoding #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdefinitelyahuman
requested changes
May 4, 2024
| @@ -283,7 +283,7 @@ def decode_typed_error(data: str) -> str: | |||
| selector = data[:10] | |||
| if selector == "0x4e487b71": | |||
| # special case, solidity compiler panics | |||
| error_code = int(data[4:].hex(), 16) | |||
| error_code = int(HexBytes(data[10:]).hex(), 16) | |||
There was a problem hiding this comment.
I think this is a safer approach, in some cases the returned data is already formatted to HexBytes. Not sure why it's inconsistent to begin with..
Suggested change
| error_code = int(HexBytes(data[10:]).hex(), 16) | |
| error_code = int(HexBytes(data)[4:].hex(), 16) |
There was a problem hiding this comment.
ahh wait i didn't zoom out enough... your approach is correct
iamdefinitelyahuman
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Related issue: #1757
How I did it
Please refer to diff.
Checklist