Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MythX analysis plugin #365

Merged
merged 15 commits into from
Mar 2, 2020
Merged

Update MythX analysis plugin #365

merged 15 commits into from
Mar 2, 2020

Conversation

dmuhs
Copy link
Contributor

@dmuhs dmuhs commented Feb 28, 2020 •
edited
Loading

What I did

  • complete refactor of the MythX plugin
  • overhaul of the plugin's test suite
  • enable AST submission for more precise results
  • update analysis modes

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

iamdefinitelyahuman
iamdefinitelyahuman requested changes Feb 29, 2020
View reviewed changes
Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for making this update! Just a couple of minor things and we'll get it merged :)

CHANGELOG.md Show resolved Hide resolved
brownie/_cli/analyze.py Outdated Show resolved Hide resolved
dmuhs and others added 2 commits March 1, 2020 21:32
@dmuhs @iamdefinitelyahuman
Update CHANGELOG.md
8d055d2 
Co-Authored-By: Ben Hauser <35276322+iamdefinitelyahuman@users.noreply.github.com>
@dmuhs
Refactor ternary operators in payload generation
65dd5e0
iamdefinitelyahuman
iamdefinitelyahuman approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamdefinitelyahuman iamdefinitelyahuman merged commit d5f3ac2 into eth-brownie:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdefinitelyahuman iamdefinitelyahuman iamdefinitelyahuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmuhs @iamdefinitelyahuman