-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified network settings and removal of config file #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This is a big one...
Related to the config file:
live
anddevelopment
and use sensible defaultsshow_colors
as an optional setting to disable colorful outputRelated to networks:
brownie networks
commandline interface for working with networksnetwork
settings inbrownie-config.yaml
Also lots of documentation updates and new tests. Closes #376
How I did it
brownie._config
, refactor how configuration settings are stored.CONFIG
is expanded to an object that holds the configuration settings, cli arg settings, and network settings~/.brownie/network-config.yaml
- a warning is raised when a project has a config file with now-deprecated network settingstests/
andcontracts/
subfolders, OR has acontracts/
subfolder with at least one.vy
or.sol
file inside it.How to verify it
Run tests.