Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing key file error. #448

Merged

Conversation

Skyge
Copy link
Contributor

@Skyge Skyge commented Apr 26, 2020

What I did

Fix #440

How I did it

Modify the function _import in the file /brownie/_cli/accounts.py and the function load in the file /brownie/network/account.py

How to verify it

Run test

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help with this! Just a couple minor edits, and it needs to be linted with black.

brownie/network/account.py Outdated Show resolved Hide resolved
brownie/network/account.py Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Apr 26, 2020

Codecov Report

Merging #448 into master will decrease coverage by 0.10%.
The diff coverage is 52.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   88.32%   88.22%   -0.11%     
==========================================
  Files          56       56              
  Lines        5904     5911       +7     
  Branches     1298     1300       +2     
==========================================
  Hits         5215     5215              
- Misses        479      484       +5     
- Partials      210      212       +2     
Impacted Files Coverage Δ
brownie/_cli/accounts.py 75.00% <16.66%> (-6.16%) ⬇️
brownie/network/account.py 92.38% <72.72%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 082e168...5527e00. Read the comment docs.

Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@iamdefinitelyahuman iamdefinitelyahuman merged commit a70ba6c into eth-brownie:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing from a Keystore
3 participants