Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not raise on non-zero block height #461

Merged
merged 4 commits into from
Apr 29, 2020
Merged

Do not raise on non-zero block height #461

merged 4 commits into from
Apr 29, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Warn instead of raising an exception when block height is > 0 in development network - Closes #453

I also got distracted and added some intersphinx docs references for web3py

How I did it

  • add brownie Warning classes, implement them in existing warnings
  • warn instead of raising on block height > 0
  • add documentation

How to verify it

Run tests.

@codecov-io
Copy link

codecov-io commented Apr 29, 2020

Codecov Report

Merging #461 into master will decrease coverage by 2.83%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
- Coverage   88.16%   85.32%   -2.84%     
==========================================
  Files          56       56              
  Lines        5981     5985       +4     
  Branches     1317     1316       -1     
==========================================
- Hits         5273     5107     -166     
- Misses        490      642     +152     
- Partials      218      236      +18     
Impacted Files Coverage Δ
brownie/network/contract.py 90.08% <0.00%> (ø)
brownie/network/main.py 87.17% <66.66%> (+2.56%) ⬆️
brownie/exceptions.py 88.40% <100.00%> (+0.71%) ⬆️
brownie/test/managers/master.py 32.25% <0.00%> (-61.30%) ⬇️
brownie/test/__init__.py 42.10% <0.00%> (-57.90%) ⬇️
brownie/test/managers/runner.py 51.57% <0.00%> (-34.22%) ⬇️
brownie/test/fixtures.py 59.74% <0.00%> (-32.47%) ⬇️
brownie/test/managers/base.py 61.70% <0.00%> (-18.09%) ⬇️
brownie/test/plugin.py 65.62% <0.00%> (-15.63%) ⬇️
brownie/test/coverage.py 86.66% <0.00%> (-13.34%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9cd721...40a6c69. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn instead of raising on block height > 0 when attaching to Ganache
2 participants