expose silent parameter to transfer #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Accounts.transfer() now accepts silent: bool as parameter and forwards it to TransactionReceipt. - Test done to check if console output is printed - Updated API docs - Added info and PR to CHANGELOG.md
iamdefinitelyahuman
approved these changes
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Exposed
silentbool parameter to Account.transfer() which will pass it on to TransactionReceipt.Setting silent = True will suppress any console output for the transaction.
Related issue: #467
How I did it
Exposed the parameter and added all the necessary tests and docs.
How to verify it
Run
test_silent_modeor in brownie console:a[0].transfer(a[1], "1 ether", silent = True)should produce no console output.Checklist