Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rpc.undo/redo with non-instant confirmations #483

Merged
merged 1 commit into from
May 4, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Handle issues with rpc.undo / redo when using non-instant confirmations with Ganache.

How I did it

Instead of adding the tx's to the undo buffer immediately, they are handled via a thread which waits for the tx to confirm.

How to verify it

Run tests.

@codecov-io
Copy link

Codecov Report

Merging #483 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   88.23%   88.24%   +0.01%     
==========================================
  Files          56       56              
  Lines        6077     6093      +16     
  Branches     1337     1340       +3     
==========================================
+ Hits         5362     5377      +15     
  Misses        494      494              
- Partials      221      222       +1     
Impacted Files Coverage Δ
brownie/network/account.py 91.81% <100.00%> (+0.11%) ⬆️
brownie/network/rpc.py 88.66% <100.00%> (+0.28%) ⬆️
brownie/network/transaction.py 86.87% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dd442...d4d2c49. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit d2878bb into master May 4, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the undo-redo-threading-fix branch May 4, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants