Expose nonce parameter #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed transfer, deploy and transact functionality to expose the nonce parameter - minor clarification in error messages - added test cases for manual nonce
Also re-ordered params for Account.transfer() to be consistent with undo() and redo()
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
==========================================
+ Coverage 78.89% 88.33% +9.44%
==========================================
Files 56 56
Lines 6089 6089
Branches 1338 1338
==========================================
+ Hits 4804 5379 +575
+ Misses 1086 489 -597
- Partials 199 221 +22
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Related issue: #484
How I did it
Added nonce as kwarg or dict element when creating a transaction. E.g.:
accounts[0].transfer(accounts[1], nonce=5)
tester.doNothing({"from": accounts[0], "nonce": 5})
How to verify it
run tests
Checklist