Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat etherscan api #492

Merged
merged 4 commits into from
May 5, 2020
Merged

Feat etherscan api #492

merged 4 commits into from
May 5, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Update Contract.from_explorer with new Etherscan API

Closes #489

How I did it

  • Compile with EVM ruleset indicated by API
  • When API provides an implementation address, use it (if no as_proxy_for address is given)

How to verify it

Run tests.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 9c32c4f into master May 5, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the feat-etherscan-api branch May 5, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Contract.from_explorer with new Etherscan API data
1 participant
@iamdefinitelyahuman