Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow path remappings in interfaces #495

Merged
merged 3 commits into from
May 5, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Allow use of packages and path remappings when compiling interfaces.

How I did it

  • Add the project.compiler.get_abi method. It uses the standard JSON input/output for compiling, similarly to how project.compiler.compile_and_format works.
  • Mark the old vyper.get_abi and solidity.get_abi methods as deprecated.

How to verify it

Run tests.

@codecov-io
Copy link

Codecov Report

Merging #495 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
- Coverage   88.33%   88.32%   -0.02%     
==========================================
  Files          56       56              
  Lines        6097     6106       +9     
  Branches     1341     1343       +2     
==========================================
+ Hits         5386     5393       +7     
- Misses        489      491       +2     
  Partials      222      222              
Impacted Files Coverage Δ
brownie/project/compiler/solidity.py 92.30% <ø> (ø)
brownie/project/compiler/vyper.py 92.92% <ø> (-1.77%) ⬇️
brownie/project/compiler/__init__.py 92.00% <100.00%> (+0.51%) ⬆️
brownie/project/main.py 90.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9293ae3...497912e. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 42fd5ac into master May 5, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the feat-interface-remappings branch May 5, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants