Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to OverloadedMethod #507

Merged
merged 7 commits into from
May 9, 2020
Merged

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Allow calls to OverloadedMethod without specifying the function signature. Closes #348

How I did it

When an overloaded method only has one function with a given number of arguments, do not require the signature to be explicitly declared.

How to verify it

Run tests. I added test cases.

@codecov-io
Copy link

codecov-io commented May 9, 2020

Codecov Report

Merging #507 into master will increase coverage by 0.02%.
The diff coverage is 92.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   88.46%   88.49%   +0.02%     
==========================================
  Files          56       56              
  Lines        6145     6178      +33     
  Branches     1357     1366       +9     
==========================================
+ Hits         5436     5467      +31     
- Misses        485      486       +1     
- Partials      224      225       +1     
Impacted Files Coverage Δ
brownie/network/contract.py 90.53% <92.50%> (-0.17%) ⬇️
brownie/network/transaction.py 87.52% <100.00%> (ø)
brownie/convert/normalize.py 86.07% <0.00%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025329e...7729fb1. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 122f2c8 into master May 9, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the feat-fn-overloading branch May 9, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to OverloadedMethod
2 participants