Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use web3.eth.generateGasPrice for gas price #530

Merged
merged 1 commit into from
May 20, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Allow use of custom gas strategies via the web3 gas price API

How I did it

  • When determining gas price, use web3.eth.generateGasPrice if no value is given in the config.
  • Set the default strategy to check eth_gasPrice

How to verify it

Run tests.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #530 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   88.44%   88.44%           
=======================================
  Files          56       56           
  Lines        6247     6249    +2     
  Branches     1380     1380           
=======================================
+ Hits         5525     5527    +2     
  Misses        493      493           
  Partials      229      229           
Impacted Files Coverage Δ
brownie/network/account.py 94.11% <100.00%> (ø)
brownie/network/web3.py 97.19% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6965f47...e0985d6. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit f99314a into master May 20, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the feat-gas-price-strategy branch May 20, 2020 12:58
@michwill
Copy link

Is it possible to choose between different gas strategies? E.g. fast/medium/slow/glacier in web3py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants