Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow wss connections #542

Merged
merged 2 commits into from
May 23, 2020

Conversation

matnad
Copy link
Collaborator

@matnad matnad commented May 23, 2020

What I did

Fix to allow wss connections.
Tested by connecting to infura using wss endpoint.

Related issue: #541

How I did it

see PR

How to verify it

Replace host for the mainnet network in the network-config.yaml file with host: wss://mainnet.infura.io/ws/v3/$WEB3_INFURA_PROJECT_ID

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #542 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files          56       56           
  Lines        6259     6259           
  Branches     1381     1381           
=======================================
  Hits         5533     5533           
  Misses        496      496           
  Partials      230      230           
Impacted Files Coverage Δ
brownie/network/web3.py 97.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c15189...9a448c2. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit f111fef into eth-brownie:master May 23, 2020
@matnad matnad deleted the fix-wss-connections branch December 28, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants