Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recompile moved contracts #545

Merged
merged 2 commits into from
May 23, 2020

Conversation

matnad
Copy link
Collaborator

@matnad matnad commented May 23, 2020

What I did

Fixed FileNotFoundError when moving a contract source file.

Closes #539

How I did it

Delete artifacts where no matching source is found and recompile the artifact.

How to verify it

Move a contract to a different folder and compile the project, then check the new artifact.

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #545 into master will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   88.43%   88.39%   -0.05%     
==========================================
  Files          56       56              
  Lines        6279     6282       +3     
  Branches     1387     1388       +1     
==========================================
  Hits         5553     5553              
- Misses        496      498       +2     
- Partials      230      231       +1     
Impacted Files Coverage Δ
brownie/project/main.py 89.52% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782c32e...a069094. Read the comment docs.

Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iamdefinitelyahuman iamdefinitelyahuman merged commit df9784c into eth-brownie:master May 23, 2020
@matnad matnad deleted the fix-moving-contracts branch December 28, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving a contract raises FileNotFoundError
3 participants