Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KeyError when handling some RPC exceptions #550

Merged
merged 1 commit into from
May 24, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Raise a ValueError when the output used to create a VirtualMachineError cannot be properly parsed. This should fix issues with KeyError when Geth complains about e.g. a hardware wallet not being unlocked, or a lack of peers.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #550 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
- Coverage   88.19%   88.17%   -0.03%     
==========================================
  Files          56       56              
  Lines        6304     6306       +2     
  Branches     1392     1393       +1     
==========================================
  Hits         5560     5560              
- Misses        514      515       +1     
- Partials      230      231       +1     
Impacted Files Coverage Δ
brownie/exceptions.py 84.15% <0.00%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408a973...33b99b7. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 8ad4c89 into master May 24, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-vm-exception branch May 24, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants