Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: web3 ipc timeout #554

Merged
merged 1 commit into from
May 26, 2020
Merged

fix: web3 ipc timeout #554

merged 1 commit into from
May 26, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

Fix how timeout arg is provided to IPCProvider

How to verify it

Connect to a client via IPC.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #554 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          56       56           
  Lines        6309     6309           
  Branches     1395     1395           
=======================================
  Hits         5560     5560           
- Misses        517      518    +1     
+ Partials      232      231    -1     
Impacted Files Coverage Δ
brownie/network/web3.py 97.19% <100.00%> (ø)
brownie/network/state.py 91.30% <0.00%> (-1.74%) ⬇️
brownie/network/rpc.py 89.92% <0.00%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b6a27...40fc7bc. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit f202287 into master May 26, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-ipc-timeout branch May 26, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants