Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest fixes #556

Merged
merged 3 commits into from
May 26, 2020
Merged

Pytest fixes #556

merged 3 commits into from
May 26, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

  • Bugfix: script imports from the stdlib
  • Add project path to sys.path prior to loading pytest
  • Improve readability of exception when compilation fails while running pytest

How to verify it

Run tests.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #556 into master will decrease coverage by 0.00%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   88.00%   88.00%   -0.01%     
==========================================
  Files          56       56              
  Lines        6312     6319       +7     
  Branches     1396     1396              
==========================================
+ Hits         5555     5561       +6     
- Misses        522      523       +1     
  Partials      235      235              
Impacted Files Coverage Δ
brownie/project/scripts.py 87.14% <66.66%> (ø)
brownie/test/plugin.py 76.31% <66.66%> (-4.94%) ⬇️
brownie/_cli/test.py 85.71% <100.00%> (+0.71%) ⬆️
brownie/network/state.py 93.04% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d07a0...906f8ec. Read the comment docs.

@iamdefinitelyahuman iamdefinitelyahuman merged commit e809ea5 into master May 26, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-pytest-import-paths branch May 26, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants