Add POA middleware #602
Merged
Add POA middleware #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdefinitelyahuman
force-pushed
the
feat-poa-middleware
branch
from
22a9833
to
b66a1e0
Compare
iamdefinitelyahuman
force-pushed
the
feat-poa-middleware
branch
from
b66a1e0
to
1127b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add
geth_poa_middlewarewhen connecting to a POA networkCloses #583
How I did it
After connecting, call
web3.eth.getBlock('latest')and catchExtraDataLengthError. If this exception is raised, add the required middleware.How to verify it
Run the tests. I added a test case to confirm connection to rinkeby works.