Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransactionReceipt fixes #665

Merged
merged 2 commits into from
Jul 5, 2020
Merged

TransactionReceipt fixes #665

merged 2 commits into from
Jul 5, 2020

Conversation

iamdefinitelyahuman
Copy link
Member

What I did

  • only add TransactionReceipt objects to history when they are broadcasted from within brownie - closes Improvements to TransactionReceipt #654
  • make TransactionReceipt's silent kwarg False by default
  • handle hexadecimal numeric values in traces (nethermind)

How to verify it

Run tests.

@iamdefinitelyahuman iamdefinitelyahuman merged commit 0a11ef4 into master Jul 5, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the fix-tx-receipt branch July 5, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements to TransactionReceipt
1 participant
@iamdefinitelyahuman