Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load project before conftest #720

Merged
merged 5 commits into from
Aug 18, 2020

Conversation

fubuloubu
Copy link
Contributor

@fubuloubu fubuloubu commented Aug 18, 2020

What I did

Fixes: #719

How I did it

Load the project config during the discovery phase of conftest.py files

How to verify it

Everything should still work, and loading contract types in conftest.py should be possible

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, couple minor things to address.

brownie/test/plugin.py Outdated Show resolved Hide resolved
brownie/test/plugin.py Outdated Show resolved Hide resolved
@fubuloubu fubuloubu force-pushed the patch-1 branch 3 times, most recently from bcfd522 to 116ad89 Compare August 18, 2020 15:45
@fubuloubu
Copy link
Contributor Author

g2g

@iamdefinitelyahuman iamdefinitelyahuman merged commit 84cf4e8 into eth-brownie:master Aug 18, 2020
@fubuloubu fubuloubu deleted the patch-1 branch August 18, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow importing contracts inside test suites
2 participants