Allow replacing pending transactions #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
reviewed
Nov 16, 2020
Comment on lines
+64
to
+65
| Pending = -1 | ||
| Reverted = 0 |
There was a problem hiding this comment.
I feel like these two should be swapped?
There was a problem hiding this comment.
0 and 1 are standard values to represent reverted and successful in a txreceipt. Brownie has used -1 for pending since forever, modifying it would be a breaking change 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add the
TransactionReceipt.replacemethod for replacing pending transactions.Closes #726
How I did it
The logic flow for creating a
TransactionReceipthad to be modified slightly. Creating the object is now optionally-blocking via theis_blockingkwarg (this had to be done to avoid making a breaking change). When broadcasting, the object is initially created via a non-blocking call, then added tohistory, then ifrequired_confsis non-zero it callswaitto block until the necessary confirmations. By using this approach, each tx object is added to history immediately, so that users canCTRL-Cand still access the pending the tx.Replacement happens via
TransactionReceipt.replacewhich accepts either anincrementmodifier orgas_priceabsolute and returns a new tx object.As soon as any one transaction confirms, the other tx's are marked with status
-2(dropped) and removed fromhistory.How to verify it
This is difficult to write tests for. I've played with it a fair bit on the mainnet and everything seems to work, but unfortunately I think the only real test here is to release and solve bugs are they appear.