Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow publishing of source on BscScan #962

Merged
merged 8 commits into from
Mar 7, 2021

Conversation

jbargu
Copy link
Contributor

@jbargu jbargu commented Feb 17, 2021

What I did

BscScan (Binance Smart Chain) is an exact copy of Etherscan. The only thing preventing from publishing the source to BscScan is the etherscan substring check in contract.py::publish_source method.

How I did it

Add a check for bscscan substring in the explorer URL check.

How to verify it

Deploy a contract on BSC mainnet with publish_source=True and explorer set to bscscan:

  ├─binance-mainnet
  │ ├─id: binance-mainnet
  │ ├─chainid: 56
  │ ├─explorer: https://api.bscscan.com/api
  │ └─host: https://bsc-dataseed1.binance.org

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases (no existing tests for explorer tests)
  • I have updated the documentation
  • I have added an entry to the changelog

@Netherdrake
Copy link

@iamdefinitelyahuman please consider merging this

Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think this should be in the same release as #961

docs/deploy.rst Outdated Show resolved Hide resolved
Co-authored-by: Ben Hauser <35276322+iamdefinitelyahuman@users.noreply.github.com>
@iamdefinitelyahuman iamdefinitelyahuman merged commit f9c9cd8 into eth-brownie:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants