Vyper nonpayable heuristic #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Adjust the heuristic for nonpayable reverts in vyper 0.2.11
Related issue: #
How I did it
In Vyper 0.2.11 the nonpayable check no longer always happens immediately upon entering the contract, it instead happens after the last payable function. I've adjusted the logic for the heuristic to be a bit looser, it checks any
REVERTwithout the source map instead of only at the very beginning of the contract.How to verify it
Confirm the tests are now passing. This is the reason for failing CI on several open PRs.