Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decode ds-note events #985

Merged
merged 3 commits into from
Mar 13, 2021

Conversation

banteg
Copy link
Collaborator

@banteg banteg commented Mar 11, 2021

What I did

Added support to decode different variants of ds-note events, commonly used across MakerDAO ecosystem.

Screen Shot 2021-03-11 at 20 08 09

Tested with:

Related issue: #

How I did it

How to verify it

network.connect('mainnet')
tx = chain.get_transaction('0x7d5799a3622477847731d22ddd8d38031a949159446a727b3e4e7542ad558806')
tx.info()

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants