Flag to run tests against project outside of current working directory #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brownie/test/plugin.py
Outdated
| @@ -12,9 +13,23 @@ | |||
| from brownie.utils import color | |||
|
|
|||
|
|
|||
| def _get_project_path() -> Optional[Path]: | |||
| if "--brownie-project" not in sys.argv[:-1]: | |||
There was a problem hiding this comment.
Note: This means --brownie-project=abcd won't work, which is also a standard way of passing args. But It's probably good enough.
There was a problem hiding this comment.
Ahh true.. that should be easy enough to support as well. Good catch!
There was a problem hiding this comment.
I am wondering, why not just add the flags in pytest_addoption, regardless of whether we are in a project dir or not?
I mean, if the user doesn't want to use brownie, he can just disable the plugin
iamdefinitelyahuman
force-pushed
the
test-project-flag
branch
from
65edd0b
to
bc12ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add a commandline flag
--brownie-projectto force loading a project outside of the current working directory when using the brownie pytest plugin.Closes #994
How I did it
Within
test/plugin.py, I've added the_get_project_pathmethod to find the current project path. Because the path required prior topytest_addoption, it must be extracted directly fromsys.argv. It's a bit hacky but it solves the issue.How to verify it
Try it.