EIP 214 - First draft #22

dziabko · 2019-05-08T22:02:44Z

Not able to run tests yet. Created a first draft implementation of EIP214.

austinabell · 2019-05-09T16:00:29Z

core/execution.go

 )

 var (
 	callCreateDepthMax = 1024 // limit call/create stack
 	errCallCreateDepth = fmt.Errorf("Max call depth exceeded (%d)", callCreateDepthMax)
+	ErrDepth           = errors.New("max call depth exceeded")


why is this needed? Can you either just make the previous line usable for both or make it so that error prints the max depth for staticcall? A side note you should probably follow casing standards and start with a lowercase for this variable if it is needed.

austinabell · 2019-05-09T16:04:43Z

core/execution.go

+	// Initialise a new contract and set the code that is to be used by the EVM.
+	// The contract is a scoped environment for this execution context only.
+	contract := vm.NewContract(caller, to, new(big.Int), gas, gasPrice).AsDelegates
+	contract.SetCallCode(&addr, evm.StateDB.GetCodeHash(addr), evm.StateDB.GetCode(addr))


Is this copied from ETH? I don't see many of these lines referencing ETC variables

austinabell · 2019-05-09T16:05:21Z

core/execution.go

+			contract.UseGas(contract.Gas)
+		}
+	}
+	return ret, contract.Gas, err


function signature has (ret []byte, err error) return, should be only two values

austinabell · 2019-05-09T16:06:12Z

core/vm/instructions.go

-var callStipend = big.NewInt(2300) // Free gas given at beginning of call.
+var (
+	callStipend          = big.NewInt(2300) // Free gas given at beginning of call.
+	errExecutionReverted = errors.New("evm: execution reverted")


This is for EIP140 REVERT opcode, which isn't currently implemented in development

austinabell · 2019-05-09T16:08:06Z

core/vm/instructions.go

@@ -511,6 +515,23 @@ func opDelegateCall(instr instruction, pc *uint64, env Environment, contract *Co
 	}
 }

+func opStaticCall(pc *uint64, env Environment, contract *Contract, memory *Memory, stack *stack) ([]byte, error) {


ETC doesn't handle returns on these functions, you should match the function signature from related calls in this file to allow you to attach it to the JumpTable reference of STATICCALL

austinabell · 2019-05-09T16:08:36Z

core/vm/jump_table.go

@@ -164,6 +164,7 @@ func newJumpTable(ruleset RuleSet, blockNumber *big.Int) vmJumpTable {
 	jumpTable[JUMP] = jumpPtr{nil, true}
 	jumpTable[JUMPI] = jumpPtr{nil, true}
 	jumpTable[STOP] = jumpPtr{nil, true}
+	jumpTable[STATICCALL] = jumpPtr{nil, true}


Should attach the opStaticCall function here

Edit: also it should be targeted toward Atlantis only, which you will be able to do once the refactor PR is merged

austinabell · 2019-05-09T16:10:25Z

core/vm/vm.go

@@ -169,6 +169,9 @@ func (evm *EVM) Run(contract *Contract, input []byte) (ret []byte, err error) {
 					fallthrough
 				case STOP: // Stop the contract
 					return nil, nil
+				case STATICCALL:


STATICCALL should not exit the vm execution (or somebody correct me) these lines either way should be removed once you attach the function to JumpTable[STATICCALL]

You need to also dynamically set gas and size in this file in the calculateGasAndSize(...) function

Edit: Use Call as reference, as well as the ETH implementation for calculating gas of the call

austinabell · 2019-05-09T16:10:48Z

go.mod

@@ -1,24 +1,39 @@
 module github.com/eth-classic/go-ethereum

 require (
+	github.com/allegro/bigcache v1.2.0 // indirect


Why was it necessary to update the go modules?

…ions. Added gas calc for StaticCall.

* Refactor and add config for Atlantis chain config * Typo fix * Refactor jump table setup * Changed fork config skipping functionality and removed unused configuration mappings * Fixed null pointer error with test configs * Added definitions of other blocks for correctly mapping gas table * Implemented IsAtlantis interface for vm runtime

* ci: create basic circle-ci config * ci: lower parallelism * ci: rename jobs * ci: rename jobs

…ions. Added gas calc for StaticCall.

…m into eip214-staticcall

…s other calls

* implemented EIP 161 logic * implemented EIP 161 logic * fixed bug * no more segfaults * Byzantium Tests Passing. Certain Homestead Failing * Fixed implementation to pass (almost) all tests * Updated testing framework to run all ETH directories * Reimpl EIP161 SUICIDE and CALL edge cases * Skip unimplemented functionality tests * proper indentation

* add go mods to bind package * attempt to fix mods * revert some dependencies

* fixed trimToImportPath for outside of go path * is this how working_directory works? * is this how working_directory works? * is this how working_directory works? * is THIS how working_directory works? * is THIS how working_directory works? * working_directory * working_directory

* Implemented EIP 140 op code framework to be tested * Added required parameters and moved protocol parameters into their own file * Removed coverage file accidentally commited * Set up testing framework for eth tests * Updated struct formatting for unmarshalling * Updated format of eth test struct and updated test files (were replaced with generated files) * Using ethereum tests submodule and updated framework for testing * Updated testing structure into subtests for better reporting and so that all test cases are tested even when one fails * Fix merge error * Removed indirect reference to ethereum/go-ethereum during rebase * Implemented EIP 140 op code framework to be tested * Added required parameters and moved protocol parameters into their own file * Removed coverage file accidentally commited * Set up testing framework for eth tests * Updated struct formatting for unmarshalling * Updated format of eth test struct and updated test files (were replaced with generated files) * Using ethereum tests submodule and updated framework for testing * Updated testing structure into subtests for better reporting and so that all test cases are tested even when one fails * Fix merge error * Removed indirect reference to ethereum/go-ethereum during rebase * WIP fixed some implementations of REVERT * Fixed more implementation details * Skipped unrelated and unimplemented tests * Implemented EIP 140 op code framework to be tested * Added required parameters and moved protocol parameters into their own file * Removed coverage file accidentally commited * Set up testing framework for eth tests * Updated struct formatting for unmarshalling * Updated format of eth test struct and updated test files (were replaced with generated files) * Using ethereum tests submodule and updated framework for testing * Updated testing structure into subtests for better reporting and so that all test cases are tested even when one fails * Fix merge error * Removed indirect reference to ethereum/go-ethereum during rebase * Implemented EIP 140 op code framework to be tested * Added required parameters and moved protocol parameters into their own file * Removed coverage file accidentally commited * Set up testing framework for eth tests * Updated struct formatting for unmarshalling * Updated format of eth test struct and updated test files (were replaced with generated files) * Using ethereum tests submodule and updated framework for testing * Updated testing structure into subtests for better reporting and so that all test cases are tested even when one fails * Fix merge error * Removed indirect reference to ethereum/go-ethereum during rebase * WIP fixed some implementations of REVERT * Fixed more implementation details * Skipped unrelated and unimplemented tests * Revert modules changes from development * Removed last gas cost variable used previously to save recalculation

* added contract size limit * added maxCodeSizeExceeded error * fixed some tests failing due to not checking for creation of contract in the OR * added IsAtlantis condition for max code size to apply. We now fail tests * removed TestETHCodeSizeLimit

…ions. Added gas calc for StaticCall.

…s other calls

GregTheGreek · 2019-05-30T22:18:31Z

Closing in favour of #40

First draft

4c06bdf

GregTheGreek mentioned this pull request May 8, 2019

Tracking EIPS #1

Closed

austinabell reviewed May 9, 2019

View reviewed changes

dziabko and others added 4 commits May 9, 2019 17:08

Fixed execStaticCall's ETH ref. Removed unecessary errors in instruct…

ac64cad

…ions. Added gas calc for StaticCall.

Removed unecessary go modules

9e6882e

Added implementation of StaticCall to tests

10d1730

soc1c added PR: 0 In Progress Type: Core labels May 14, 2019

austinabell and others added 14 commits May 15, 2019 09:30

Added fix for testing some fork subtests EIP150 and Frontier (#27)

c91dd38

ci: create basic circle-ci config (#26)

f0ac799

* ci: create basic circle-ci config * ci: lower parallelism * ci: rename jobs * ci: rename jobs

First draft

76ae058

Fixed execStaticCall's ETH ref. Removed unecessary errors in instruct…

3ab0fe3

…ions. Added gas calc for StaticCall.

Removed unecessary go modules

2a577cf

Added implementation of StaticCall to tests

b262d8a

Merge branch 'eip214-staticcall' of github.com:eth-classic/go-ethereu…

d90fcb8

…m into eip214-staticcall

Restructured static call params to follow similar calling structure a…

933cadb

…s other calls

Elizabeth/fix bindings test (#30)

5c3969f

* add go mods to bind package * attempt to fix mods * revert some dependencies

EIP 170, contract size limit (#23)

08ef773

* added contract size limit * added maxCodeSizeExceeded error * fixed some tests failing due to not checking for creation of contract in the OR * added IsAtlantis condition for max code size to apply. We now fail tests * removed TestETHCodeSizeLimit

First draft

282cfdd

dziabko added 8 commits May 24, 2019 15:03

Fixed execStaticCall's ETH ref. Removed unecessary errors in instruct…

600a074

…ions. Added gas calc for StaticCall.

Removed unecessary go modules

b971191

Added implementation of StaticCall to tests

bafb553

Restructured static call params to follow similar calling structure a…

37e20ae

…s other calls

Rebased with dev branch

e0d4a7d

Rebased with dev branch

3373805

Rebased with dev

da71442

Fixed rebase w/ development not including REVERT everywhere

3fabc96

GregTheGreek closed this May 30, 2019

soc1c deleted the eip214-staticcall branch June 10, 2019 20:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EIP 214 - First draft #22

EIP 214 - First draft #22

dziabko commented May 8, 2019

austinabell May 9, 2019

austinabell May 9, 2019

austinabell May 9, 2019

austinabell May 9, 2019

austinabell May 9, 2019

austinabell May 9, 2019 •

edited

Loading

austinabell May 9, 2019

austinabell May 9, 2019 •

edited

Loading

austinabell May 9, 2019

GregTheGreek commented May 30, 2019

EIP 214 - First draft #22

EIP 214 - First draft #22

Conversation

dziabko commented May 8, 2019

austinabell May 9, 2019

Choose a reason for hiding this comment

austinabell May 9, 2019

Choose a reason for hiding this comment

austinabell May 9, 2019

Choose a reason for hiding this comment

austinabell May 9, 2019

Choose a reason for hiding this comment

austinabell May 9, 2019

Choose a reason for hiding this comment

austinabell May 9, 2019 • edited Loading

Choose a reason for hiding this comment

austinabell May 9, 2019

Choose a reason for hiding this comment

austinabell May 9, 2019 • edited Loading

Choose a reason for hiding this comment

austinabell May 9, 2019

Choose a reason for hiding this comment

GregTheGreek commented May 30, 2019

austinabell May 9, 2019 •

edited

Loading

austinabell May 9, 2019 •

edited

Loading