This repository has been archived by the owner on Aug 13, 2019. It is now read-only.
Makefile fix with go modules #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
dziabko,
GregTheGreek,
meowsbits and
steviezhang
noot
approved these changes
Jun 14, 2019
steviezhang
approved these changes
Jun 14, 2019
soc1c
approved these changes
Jun 14, 2019
dziabko
pushed a commit
that referenced
this pull request
Jun 20, 2019
dziabko
pushed a commit
that referenced
this pull request
Jun 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously didn't test every makefile command inside of the $GOPATH but since go modules is by default off and the flag set at the start of the command didn't persist, it went back to non-modules interactions.