Skip to content
This repository has been archived by the owner on Aug 13, 2019. It is now read-only.

ci: prepare assets for release #64

Merged
merged 12 commits into from
Jun 17, 2019
Merged

ci: prepare assets for release #64

merged 12 commits into from
Jun 17, 2019

Conversation

soc1c
Copy link
Contributor

@soc1c soc1c commented Jun 17, 2019

Creates artifacts on CircleCI we can use for releases:

  • geth-classic-v6.0.1-16-g7f356f2-linux.tar.gz
  • geth-classic-v6.0.1-16-g7f356f2-linux.sha256

@soc1c
Copy link
Contributor Author

soc1c commented Jun 17, 2019

We have binaries!

Screenshot_2019-06-17 Continuous Integration and Deployment

@soc1c soc1c marked this pull request as ready for review June 17, 2019 09:57
@soc1c soc1c requested a review from noot as a code owner June 17, 2019 09:57
GregTheGreek
GregTheGreek previously approved these changes Jun 17, 2019
Copy link

@GregTheGreek GregTheGreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment would be that technically it works for osx as well as linux

@GregTheGreek GregTheGreek dismissed their stale review June 17, 2019 19:15

Should add release feature

Copy link

@GregTheGreek GregTheGreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should upload the artifacts for us :)

.circleci/config.yml Show resolved Hide resolved
@GregTheGreek
Copy link

I'll add auto deploy in a seperate PR :) Good to go @soc1c

@soc1c soc1c merged commit 3512b59 into development Jun 17, 2019
@soc1c soc1c deleted the s1-ci-release branch June 17, 2019 20:38
dziabko pushed a commit that referenced this pull request Jun 20, 2019
* ci: prepare assets for release

* ci: fix indentation

* ci: fix indentation

* ci: fix indentation

* ci: fix indentation

* ci: release in build step

* ci: calculate sha256sums

* ci: store artifacts

* ci: do a reverse copy

* ci: fix bash syntax

* ci: indicate os in release

* ci: pushd and pop'd ;)
dziabko pushed a commit that referenced this pull request Jun 20, 2019
* ci: prepare assets for release

* ci: fix indentation

* ci: fix indentation

* ci: fix indentation

* ci: fix indentation

* ci: release in build step

* ci: calculate sha256sums

* ci: store artifacts

* ci: do a reverse copy

* ci: fix bash syntax

* ci: indicate os in release

* ci: pushd and pop'd ;)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants