Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Spack +test variant #10

Merged
merged 4 commits into from
May 31, 2024
Merged

Fix Spack +test variant #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c36622
test pipeline
RMeli May 29, 2024
3ad20a3
set MPIEXEC_MAX_NUMPROCS explicitly with +test
RMeli May 29, 2024
b503091
simplify
RMeli May 29, 2024
aaee74a
changelog
RMeli May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## DLA-Future-Fortran X.Y.Z

### Fixed

* Spack installation with `+test` variant by setting `-DMPIEXEC_MAX_NUMPROCS=6` [PR #10]

## DLA-Future-Fortran 0.1.0

First release of [DLA-Future-Fortran], a Fortran interface for [DLA-Future].
Expand Down
6 changes: 5 additions & 1 deletion spack/packages/dla-future-fortran/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@ def cmake_args(self):
args = []

args.append(self.define_from_variant("BUILD_SHARED_LIBS", "shared"))
args.append(self.define_from_variant("DLAF_FORTRAN_BUILD_TESTING", "test"))

if self.spec.satisfies("+test"):
args.append(self.define("DLAF_FORTRAN_BUILD_TESTING", True))
# Tests run with 6 MPI ranks
args.append(self.define("MPIEXEC_MAX_NUMPROCS", 6))

# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
# FIXME: Variables only available on the DLA-Future-Fortran repo
Expand Down
Loading