Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the 'calldataCost' from the 'callGasLimit' to 'validationGasLimit' #7

Merged

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    288e00c View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    0d9f054 View commit details
    Browse the repository at this point in the history
  2. Move the 'calldataCost' from the 'callGasLimit' to 'validationGasLimit'

    It is reasonable to assume the "inner" call is the first piece of data
    known to the transaction sender.
    This includes the gas limit needed for the "inner" call to happen.
    However, the 'calldataCost' also depends on the validation and paymaster
    data, creating a chicken-or-egg problem.
    
    Moving the costs of caldata to validation defers the calculation of
    expected calldata cost and allows solving the paradox in most cases.
    forshtat committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d437c71 View commit details
    Browse the repository at this point in the history