This repository has been archived by the owner on Mar 12, 2023. It is now read-only.
Refactors JWT struct to support additional Apple services. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ethanhuang13 Is there anything I can do to help with getting this PR merged? If you have suggestions on an alternative approach for adding App Store Connect support, I'm happy to help with that. Thanks. |
|
Hi, sorry for the waiting. I just need a vacation to look into it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the JWT struct into a generic called JsonWebToken and a wrapper called JWT (in order to maintain code compatibility with existing clients).
Provides two alternative usage samples in the Readme file, demonstrating how a client can construct an APNs or App Store Connect JWT. This approach lends itself to supporting the specific needs of additional Apple server services.