Do not declare isReactComponent #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanselzer
requested changes
Sep 8, 2018
| @@ -430,14 +430,10 @@ export default class extends React.Component { | |||
| return e.touches[0]; | |||
| } | |||
|
|
|||
| isReactComponent(reactElement) { | |||
There was a problem hiding this comment.
Hi @jacekradko - What is your opinion of keeping the method but changing the name togetIsReactComponent to avoid name collision? I like the method because its name expresses its purpose.
There was a problem hiding this comment.
Sounds good to me. Conveying intent is important.
|
Hi @jacekradko - Thanks for identifying this issue and providing a fix. You are awesome! I made a comment on the code. Please have a look and let me know your thoughts. Thanks! |
|
@ethanselzer I made the changes as you suggested. Same in react-hover-observer |
ethanselzer
approved these changes
Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the React 16.5.0 release, this component's use of
isReactComponentbreaks React'sshouldConstructcheck. Here is a more detailed explanation of the problem: facebook/react#13580Here is a working demo of the bug: https://codesandbox.io/s/nm1nn0374